Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rpath linker option when using a custom sqlite #1654

Merged
merged 1 commit into from Feb 4, 2023
Merged

Fix rpath linker option when using a custom sqlite #1654

merged 1 commit into from Feb 4, 2023

Commits on Nov 8, 2022

  1. Fix rpath linker option when using a custom sqlite 

    It seems that an old refactoring (~8 years) made a mistake on the way conditions are expressed in gyp.
the "conditions" key cannot be set 2 times and the conditions should be all set in the "conditions" array.

The impact of this bug is that when sqlite3 is compiled against a custom sqlite3 source tree, the sqlite3 runtime keeps linking with the system sqlite3 instead of linking to the custom compiled sqlite3 library. In my case that lead to a SIGSEGV upon loading an extension.
    @jeromew
    jeromew committed Nov 8, 2022
    Copy the full SHA
    b2ee99b View commit details
    Browse the repository at this point in the history