Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue of duplicate CRSs being generated on joining community #2321 #2399

Open
wants to merge 3 commits into
base: 2.2.0
Choose a base branch
from

Conversation

ikoenigsknecht
Copy link
Collaborator

@ikoenigsknecht ikoenigsknecht commented Apr 2, 2024

  • Run store.load on certificatesRequestStore to avoid our local state being overwritten temporarily on sync
  • Dedupe peer list to avoid potentially having useless information in the peer list

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@ikoenigsknecht ikoenigsknecht changed the title Fix issue of duplicate CRSs being generated on joining community Fix issue of duplicate CRSs being generated on joining community #2321 Apr 2, 2024
@ikoenigsknecht
Copy link
Collaborator Author

Fixes #2321

@ikoenigsknecht ikoenigsknecht changed the base branch from develop to 2.2.0 April 4, 2024 15:58
@holmesworcester
Copy link
Contributor

Let's merge this soon if it fixes the problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants