-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Urgent updates for 2021 #59
base: master
Are you sure you want to change the base?
Conversation
(jest-matcher-deep-close-to v3) with a Webpack treeshake test case as needed due to variation of Webpack treeshake variation between Linux, Windows, and macOS known to be needed with both Webpack v4 & recent Webpack v5 releases
* add GitHub workflow for Node.js CI testing from template, with some updates: - switch to Yarn - remove use of npm cache - always do npm run build - update workflow name - move comment for node-version * update variation in "handle umd with esm" case * use matrix to for CI build on Ubuntu, Windows, macOS * expand node-version list & add TODO comment * cleanup some comments * remove .travis.yml ref: #1
- @babel/cli -> ^7.16.0 - @babel/core -> ^7.16.0 - @babel/preset-env -> ^7.16.4 - @babel/preset-flow -> ^7.16.0
(seems to be not needed here)
(seems to be not needed here)
update API call as needed by acorn@8
update 2 test cases for Rollup 2.0.0, 2.10.x vs 2.60.x
which seems to be already covered by `yarn` installation command
@TrySound is there any chance you would be willing to consider some of the updates that I had proposed? Is there anything we can do to help make this happen? I would be happy to split this into multiple PRs if needed. I did start maintaining my own fork to solve an issue with testing Thanks in advance for your consideration. I think the most important things are to get this working with GitHub CI workflows and update to Webpack 5. |
updated:
jest-matcher-deep-close-to
flow-typed
items (seem to be obsolete & not needed)I think this needs a new 0.x version due to the nature of switching to Webpack v5.
Motivation:
I had to apply an ugly workaround to get
react-recompose
CI working on Node.js 17, would like to get it fixed in this Rollup plugin if possible.I would be happy to break this down to multiple PRs or combine some of the proposed commits if needed to get this reviewed and hopefully merged.
Thanks in advance!