Quickstart switch to pytest instead of nose #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CastixGitHub
force-pushed
the
quickstart-pytest
branch
from
330682b
to
d8c9f69
Compare
CastixGitHub
force-pushed
the
quickstart-pytest
branch
from
d8c9f69
to
3610c44
Compare
amol-
reviewed
Feb 23, 2021
devtools/gearbox/quickstart/template/+package+/tests/_conftest/app.py_tmpl
Outdated
Show resolved
Hide resolved
amol-
reviewed
Feb 23, 2021
| ('/manage_permission_only', 'editor', 403), | ||
| ('/editor_user_only', 'manager', 403), | ||
| ('/editor_user_only', 'editor', 200), | ||
| )) |
amol-
reviewed
Feb 23, 2021
| 'it may have already been added:') | ||
| import traceback | ||
| print(traceback.format_exc()) | ||
| print('Continuing with bootstrapping...') |
There was a problem hiding this comment.
Well, in the case of sqlalchemy the error was managed because we could do something. We could rollback. In the case of Ming it doesn't expose yet any integration with the transaction system, so I'm not sure there is much we can do. But I'm ok with leaving this in place.
amol-
reviewed
Feb 23, 2021
CastixGitHub
force-pushed
the
quickstart-pytest
branch
from
cf77123
to
b9b3e64
Compare
CastixGitHub
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As stated by nose doc https://nose.readthedocs.io/en/latest/ it also have some little issues that are just frustrating:
the effort required by porting from nose to nose2 seems the same as porting from nose to pytest, so the whole test suite in this PR was almost rebuilt from scratch :)
tested against all available options
always 100% code coverage of the quickstarted project whatever options you use
still draft because we need to: