Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow groups of groups of transactions #148

Conversation

kieranroneill
Copy link
Contributor

Description

Please explain the changes you made here

The Kibisis client was not handling the case when groups of groups of transactions were being sent.

This fix attempts to rectify this by flattening the transactions before they are transmitted to the Kibisis wallet.

Checklist

Please, make sure to comply with the checklist below before expecting review

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@kieranroneill kieranroneill marked this pull request as ready for review April 29, 2024 07:05
src/clients/kibisis/client.ts Outdated Show resolved Hide resolved
@drichar
Copy link
Collaborator

drichar commented May 15, 2024

This is the error I get now when I try signing and sending the test transaction in Storybook:

image

@kieranroneill
Copy link
Contributor Author

This fix is part of the wider Kibisis client overhaul in #174

@kieranroneill kieranroneill deleted the fix/allow-groups-of-groups-of-transactions branch May 29, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot send more than 16 groups of groups of transactions
2 participants