Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Symbol.hasInstance support #550

Merged
merged 2 commits into from
May 2, 2019
Merged

Add Symbol.hasInstance support #550

merged 2 commits into from
May 2, 2019

Conversation

ark120202
Copy link
Contributor

@ark120202 ark120202 commented May 2, 2019 •
edited

Also made it throw when right-hand side is not a table.
Because of that null instanceof Object test started failing, so added a correct implementation for instanceof Object.

@ark120202 ark120202 marked this pull request as ready for review May 2, 2019 12:15
tomblind
tomblind approved these changes May 2, 2019
View reviewed changes
Copy link
Collaborator

@tomblind tomblind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a InstanceOfFunction at some point too. But that doesn't need to be in this PR.

@Perryvw Perryvw merged commit 1d2cd13 into TypeScriptToLua:master May 2, 2019
@ark120202 ark120202 deleted the symbol-has-instance branch November 26, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomblind tomblind tomblind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ark120202 @tomblind @Perryvw