Load custom transformers from tsconfig #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolleko
reviewed
May 2, 2019
| @@ -39,13 +39,15 @@ | |||
| "node": ">=8.5.0" | |||
| }, | |||
| "dependencies": { | |||
| "resolve": "^1.10.1", | |||
There was a problem hiding this comment.
I think it's necessary in this case. Module resolution algorithm is complex and TS implementation isn't exposed and limited to types only. It's quite small, has only one sub-dependency and pretty much standard for customized module resolution, so IMO it's okay to add it. We'll need it for module support as well.
Perryvw
reviewed
May 2, 2019
ark120202
force-pushed
the
load-custom-transformers
branch
from
90b1ccc
to
de282fe
Compare
Perryvw
approved these changes
May 6, 2019
|
Since microsoft/TypeScript#31301 was merged we should remove bundle check once we'll upgrade to 3.5. |
lolleko
approved these changes
May 20, 2019
ark120202
force-pushed
the
load-custom-transformers
branch
from
0edf0dc
to
ccc28e3
Compare
Perryvw
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #433.