Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReflectionKind.Inheritable should include accessors #1742

Closed
jonchardy opened this issue Oct 19, 2021 · 0 comments
Closed

ReflectionKind.Inheritable should include accessors #1742

jonchardy opened this issue Oct 19, 2021 · 0 comments
Labels
bug Functionality does not match expectation

Comments

@jonchardy
Copy link
Contributor

Search terms

inheritable, accessors

Expected Behavior

Accessor reflections should be marked as inherited upon creation of the declaration.

Actual Behavior

In typedoc-plugin-no-inherit, accessors can't be filtered due to Reflection.inheritedFrom not being set at the time onDeclaration fires. This seems like it's a result of ReflectionKind.Inheritable not including accessors, and therefore accessors being skipped by ImplementsPlugin.getExtensionInfo. The inherited information is set later, as the inherited toggle on the page properly filters accessors.

Steps to reproduce the bug

See https://github.com/jonchardy/typedoc-plugin-no-inherit-test.

  1. npm i
  2. npm run doc
  3. Views docs/classes/Mammal.html, which should not include "test" accessor.

Environment

  • Typedoc version: 0.22.6
  • TypeScript version: 4.4.4
@jonchardy jonchardy added the bug Functionality does not match expectation label Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation
Projects
None yet
Development

No branches or pull requests

1 participant