Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit d.ts files when mode is write-tsbuildinfo #677

Closed
wants to merge 2 commits into from

Conversation

adriangodong
Copy link
Contributor

This PR updates the write logic to also emit files ending with d.ts when mode is set to write-tsbuildinfo. This allows the plugin to work together with ts-loader or babel-loader and emits d.ts files without needing to run tsc.

@piotr-oles
Copy link
Collaborator

Why don't you use write-references instead?

@adriangodong
Copy link
Contributor Author

Why don't you use write-references instead?

Wouldn't that mode overwrite the output of ts-loader?

@piotr-oles
Copy link
Collaborator

Ah, right. Could you add write-dts mode instead to keep it backward compatible?

@adriangodong
Copy link
Contributor Author

Closing this in favor of a new mode, write-dts, implemented in #679

@adriangodong adriangodong deleted the patch-1 branch November 24, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants