Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speeds up project reference build and doesnt store the result in memory #1202

Merged
merged 6 commits into from Oct 24, 2020

Conversation

sheetalkamat
Copy link
Contributor

@sheetalkamat sheetalkamat commented Oct 23, 2020

Given the project references output files are no more in memory but have to be written to disk in order for webpack to handle symlinks, we dont need in memory read and cache of input/output files from project references. They are on disk and handled it that way.

This speeds up upto-date check to behave just like what tsc -b would do so that we are not reading files in memory.
This was done as part of investigation for a team who was running into OOM and slower builds on huge project.

@johnnyreilly
Copy link
Member

johnnyreilly commented Oct 24, 2020

This is amazing work @sheetalkamat! Thank you!

I've added this to the CHANGELOG.md and updated the version in the package.json. (I also change the casing of a letter in a function name by 1 character to satisfy my OCD tendencies 😄 )

I'll plan to publish this later today assuming the build plays nice. Thank you so much!

@johnnyreilly johnnyreilly merged commit 95050eb into master Oct 24, 2020
@johnnyreilly johnnyreilly deleted the referencesAreOnDisk branch October 24, 2020 11:23
This was referenced Oct 26, 2020
@berickson1
Copy link
Contributor

This has actually resulted in a huge perf regression in our builds. Now all incremental builds are as slow as clean builds(~3 minutes). Is there any debugging logs I can gather - I don't really want to blindly submit a non-actionable bug since this doesn't repo in a small test repo.

This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants