Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize fileExists callback path #1266

Merged
merged 2 commits into from
Mar 11, 2021

Commits on Mar 10, 2021

  1. Optimize fileExists callback path

    Instead of looking up filePathKey twice, cache in in the local scope. This isn't a hugely expensive lookup path, but is a hot path on large project recompiles (especially after caches are blown away). Profiling shows that even the Map lookup shows non-trivial cache lookup aggregate time
    berickson1 committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    b6029eb View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Configuration menu
    Copy the full SHA
    2b8fc3c View commit details
    Browse the repository at this point in the history