Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #1287 to v8 #1291

Merged

Conversation

JasonKleban
Copy link

Backport "Use caches for module resolution and type reference directives when using compiler default functions" #1287 to v8

@johnnyreilly is this the right branch for any version 8 patches?

CC @sheetalkamat

@johnnyreilly
Copy link
Member

@johnnyreilly is this the right branch for any version 8 patches?

It is yes - I've never tried publishing from a branch that isn't main using the GitHub Actions workflow. Wonder if it works....

@johnnyreilly
Copy link
Member

Failing comparison tests - you may want to regenerate the output for the failing tests. See https://github.com/TypeStrong/ts-loader/tree/main/test/comparison-tests#regenerating-test-data

@johnnyreilly
Copy link
Member

I think you may have regenerated all of the test output, rather than just the failing test cases?

@JasonKleban
Copy link
Author

JasonKleban commented Apr 22, 2021

I regenerated the tests, but I don't think they'll succeed on the server check happening now. There are trivial differences and root path differences.

image

And I'm not expecting so many differences anyway.

@johnnyreilly
Copy link
Member

Yeah - I think there's something wrong with your backport

@JasonKleban
Copy link
Author

@johnnyreilly gonna need some help please. I don't know what I'm looking at.

@johnnyreilly
Copy link
Member

So to regenerate the failing test I did this: yarn run comparison-tests -- --save-output --single-test projectReferencesSymLinks

@JasonKleban
Copy link
Author

Yes, I ran exactly that (although I also ran "instance" since that one was also listed as failing, from my reading).

@johnnyreilly
Copy link
Member

I did it in the context of ts-loaders devcontainer (but that shouldn't matter). Looks like bad things are happening in GitHub Actions at the moment; seeing random failures

@johnnyreilly
Copy link
Member

yarn run comparison-tests -- --single-test projectReferencesSymLinks_WatchApi --save-output

@JasonKleban
Copy link
Author

good, right?

@johnnyreilly
Copy link
Member

Yup - good. This is where we find out if the automation works for the non-main branch...

@johnnyreilly johnnyreilly merged commit 6787a39 into TypeStrong:webpack-4 Apr 23, 2021
@johnnyreilly
Copy link
Member

https://github.com/TypeStrong/ts-loader/actions/runs/778506165

@johnnyreilly
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants