Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom transformer when building solution references #1550

Commits on Nov 21, 2022

  1. Refactor getting custom transformer into a dedicated function

    This allows us to share the function between `initializeInstance` and
    `makeSolutionBuilderHost`. `makeSolutionBuilderHost` is called as a part
    of `buildSolutionReferences`.  `buildSolutionReferences` is called before
    `initializeInstance` where the custom transformers are initialized.
    feosuna1 committed Nov 21, 2022
    Copy the full SHA
    3720126 View commit details
    Browse the repository at this point in the history
  2. Implement getCustomTransformer in makeSolutionBuilderHost

    This allows us to pass on the custom transformer while the project
    references are built.
    feosuna1 committed Nov 21, 2022
    Copy the full SHA
    ece3ea2 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. Copy the full SHA
    cc36048 View commit details
    Browse the repository at this point in the history
  2. Remove redundant .toString

    `options.configFilePath` is always a string, there's no reason we need `toString()` too.
    feosuna1 committed Nov 25, 2022
    Copy the full SHA
    7c20481 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2022

  1. Runtime check that project is a string

    In a previous commit, I removed `.toString()` without validating what
    the Typescript compiler would say. This change does a runtime check
    that the project variable is an actual string.
    feosuna1 committed Nov 26, 2022
    Copy the full SHA
    ed3f70f View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Copy the full SHA
    0ca0902 View commit details
    Browse the repository at this point in the history