typecheck the error on index.ts and do the necessary convertions

[ghost]

My proposal to fix #792

[johnnyreilly]

Interesting - could you elaborate on what you feel the advantage of this approach is over #792 please?

[ghost]

It will print something meaningful even if ts-loader catch’s a strange object as an error. I think that we can’t really trust on the error shape because some plugin might be messing things around. It will also keep the existing behavior for the expected error objects.

[johnnyreilly]

I'm not sure if I want to go to this level of error interrogation or not. I need to think about it a little.

@linxiaowu66 do you have a view on this? Your approach is simpler which is initially appealing to me. Would this PR deal with your concerns? Does it have any advantages / disadvantages that you're aware of?

[ghost]

@johnnyreilly sure :), both options do the job, I was just guessing if it broke once due to receiving some unexpected shape it might break again on something similar

[johnnyreilly]

Thanks @systemmetaphor - I'll have a think. I'm going to go with one of these approaches. Just need to decide which 😄

[johnnyreilly]

Thanks for your efforts @systemmetaphor. I've decided to go with the initial PR for simplicities sake. I hope that's okay with you - and even though your PR hasn't landed I hope you understand why and aren't too discouraged! Much ❤️

[ghost]

:) no problem