Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lists typescript as a peer dependency #841

Merged
merged 2 commits into from Sep 25, 2018
Merged

Lists typescript as a peer dependency #841

merged 2 commits into from Sep 25, 2018

Conversation

arcanis
Copy link
Contributor

@arcanis arcanis commented Sep 25, 2018

ts-loader currently relies on the hoisting in order to have access to the typescript package

It causes issues with package trees that do not support hoisting, such as Yarn Plug'n'Play.

Should fix #839 馃槂

@arcanis arcanis mentioned this pull request Sep 25, 2018
Closed
@johnnyreilly
Copy link
Member

Thanks! I'll try and get this shipped soon.

@johnnyreilly johnnyreilly merged commit 9de3df4 into TypeStrong:master Sep 25, 2018
@johnnyreilly
Copy link
Member

https://github.com/TypeStrong/ts-loader/releases/tag/v5.2.1

@arcanis
Copy link
Contributor Author

arcanis commented Sep 25, 2018

Thanks!

@arcanis arcanis deleted the patch-1 branch September 25, 2018 22:46
@johnnyreilly johnnyreilly mentioned this pull request Oct 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript should be a peerdependency
2 participants
@arcanis @johnnyreilly