Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interactive flag so that it forces REPL even when stdin is not a tty #1019

Merged
merged 2 commits into from Apr 26, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/bin.ts
Expand Up @@ -227,7 +227,8 @@ export function main (argv: string[]) {
Module.runMain()
} else {
// Piping of execution _only_ occurs when no other script is specified.
if (process.stdin.isTTY) {
// --interactive flag forces REPL
if (interactive || process.stdin.isTTY) {
startRepl(service, state, code)
} else {
let buffer = code || ''
Expand Down
15 changes: 15 additions & 0 deletions src/index.spec.ts
Expand Up @@ -260,6 +260,21 @@ describe('ts-node', function () {
cp.stdin!.end('true')
})

it('should run REPL when --interactive passed and stdin is not a TTY', function (done) {
const cp = exec(`${cmd} --interactive`, function (err, stdout) {
expect(err).to.equal(null)
expect(stdout).to.equal(
'> 123\n' +
'undefined\n' +
'> '
)
return done()
})

cp.stdin!.end('console.log("123")\n')

})

it('should support require flags', function (done) {
exec(`${cmd} -r ./tests/hello-world -pe "console.log('success')"`, function (err, stdout) {
expect(err).to.equal(null)
Expand Down