Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix REPL bug with previous line carryover #1480

Merged
merged 8 commits into from Oct 6, 2021
Merged

Fix REPL bug with previous line carryover #1480

merged 8 commits into from Oct 6, 2021

Commits on Oct 1, 2021

  1. Fix expressions carrying over from the previous line

    @TheUnlocked
    TheUnlocked committed Oct 1, 2021
    Copy the full SHA
    58136fc View commit details
    Browse the repository at this point in the history

  2. Simplify semicolon insertion logic and avoid issues with line number

    @TheUnlocked
    TheUnlocked committed Oct 1, 2021
    Copy the full SHA
    336ea8f View commit details
    Browse the repository at this point in the history

  3. fix-previous-line-carryover: Add tests, simplify code, remove dead code

    @TheUnlocked
    TheUnlocked committed Oct 1, 2021
    Copy the full SHA
    54be546 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2021

  1. Minor refactor of ASI and and test tweak

    @TheUnlocked
    TheUnlocked committed Oct 2, 2021
    Copy the full SHA
    d5eff7d View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2021

  1. Fix linting issue

    @TheUnlocked
    TheUnlocked committed Oct 3, 2021
    Copy the full SHA
    8a5bec8 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2021

  1. Avoid adding a semicolon if one already exists, since TS emits double… 

    …-semicolons

as empty statements and this *might* affect stack trace line numbers at
some point
    @cspotcode
    cspotcode committed Oct 6, 2021
    Copy the full SHA
    126b09f View commit details
    Browse the repository at this point in the history

  2. lint-fix

    @cspotcode
    cspotcode committed Oct 6, 2021
    Copy the full SHA
    1c90eb9 View commit details
    Browse the repository at this point in the history

  3. Add test case for avoiding double-semicolons; also fix tests to allow… 

    … console.log() capture
    @cspotcode
    cspotcode committed Oct 6, 2021
    Copy the full SHA
    63385d6 View commit details
    Browse the repository at this point in the history