Fix #2200

TypeStrong · Mar 16, 2023 · d2057a1 · d2057a1
1 parent 09aa616
commit d2057a1
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 3 deletions.
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -11,7 +11,7 @@
                 "--config",
                 "${workspaceFolder}/.config/mocha.fast.json",
                 "-g",
-                "2135"
+                "2200"
             ],
             "internalConsoleOptions": "openOnSessionStart",
             "name": "Debug Tests",

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,14 @@
 # Unreleased
 
+### Bug Fixes
+
+-   Fixed a bug where optional properties were not appropriately marked as optional, #2200.
+-   Fixed shifted navigation pane on devices 1024px wide, #2191.
+
+### Thanks!
+
+-   @futurGH
+
 ## v0.23.26 (2023-02-26)
 
 ### Features

diff --git a/src/lib/converter/symbols.ts b/src/lib/converter/symbols.ts
@@ -633,9 +633,13 @@ function convertProperty(
         (ts.isPropertyDeclaration(declaration) ||
             ts.isPropertySignature(declaration) ||
             ts.isParameter(declaration) ||
-            ts.isPropertyAccessExpression(declaration))
+            ts.isPropertyAccessExpression(declaration) ||
+            ts.isPropertyAssignment(declaration))
     ) {
-        if (!ts.isPropertyAccessExpression(declaration)) {
+        if (
+            !ts.isPropertyAccessExpression(declaration) &&
+            !ts.isPropertyAssignment(declaration)
+        ) {
             parameterType = declaration.type;
         }
         setModifiers(symbol, declaration, reflection);

diff --git a/src/test/converter2/issues/gh2200.ts b/src/test/converter2/issues/gh2200.ts
@@ -0,0 +1,5 @@
+declare function buildObj<T>(x: T): {
+    [K in keyof T]?: 1;
+};
+
+export const Test = buildObj({ x: 1 });
diff --git a/src/test/issueTests.ts b/src/test/issueTests.ts
@@ -854,4 +854,13 @@ export const issueTests: {
         equal(def.type?.type, "intrinsic");
         equal(def.type.toString(), "undefined");
     },
+
+    gh2200(project) {
+        const Test = query(project, "Test");
+        equal(Test.type?.type, "reflection" as const);
+        equal(
+            Test.type.declaration.getChildByName("x")?.flags.isOptional,
+            true
+        );
+    },
 };