Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Module declaration parsed as namespace #1301

Merged
merged 5 commits into from May 15, 2020
Merged

fix: Module declaration parsed as namespace #1301

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c5d021e
Fix module declaration parsed as namespace
Unnvaldr May 12, 2020
f3fe47f
Fix double equal sign instead of triple
Unnvaldr May 12, 2020
c36cb67
Fix module not being considered a namespace
Unnvaldr May 13, 2020
bc4b8b4
Refactor method of the consideration of the node as module
Unnvaldr May 14, 2020
e6cc71c
Fix inline constant instead of using enum property
Unnvaldr May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lib/converter/nodes/module.ts
View file
Open in desktop
Expand Up @@ -24,7 +24,9 @@ export class ModuleConverter extends ConverterNodeComponent<ts.ModuleDeclaration
convert(context: Context, node: ts.ModuleDeclaration): Reflection | undefined {
const reflection = context.isInherit && context.inheritParent === node
? <DeclarationReflection> context.scope
: createDeclaration(context, node, ReflectionKind.Namespace);
: createDeclaration(context, node, node.name.kind === 10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the kind is fine (that's all the function does) but the inline constant could break across different TS versions. We should instead use the enum.

Suggested change
: createDeclaration(context, node, node.name.kind === 10
: createDeclaration(context, node, node.name.kind === ts.SyntaxKind.StringLiteral

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have time later today or tomorrow to pull this down and fix if you don't have time.

? ReflectionKind.Module
: ReflectionKind.Namespace);
context.withScope(reflection, () => {
if (node.body) {
this.owner.convertNode(context, node.body);
Expand Down