Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to warn on undocumented items #1819

Merged
merged 11 commits into from Jan 23, 2022
Merged

Add option to warn on undocumented items #1819

merged 11 commits into from Jan 23, 2022

Conversation

Nokel81
Copy link
Contributor

@Nokel81 Nokel81 commented Dec 7, 2021

Resolves #1817

Gerrit0
Gerrit0 requested changes Dec 11, 2021
View reviewed changes
Copy link
Collaborator

@Gerrit0 Gerrit0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

src/lib/validation/documentation.ts Show resolved Hide resolved
src/lib/validation/documentation.ts Outdated Show resolved Hide resolved
@Nokel81
fix off by one error
0724686 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Fix off by one error on reporting
f769611
Gerrit0
Gerrit0 requested changes Jan 3, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/lib/validation/documentation.ts Outdated Show resolved Hide resolved
@Nokel81
Fix changelog, change ignore node_modules check
b563d92 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 requested a review from Gerrit0 January 4, 2022 21:52
@Gerrit0 Gerrit0 merged commit 122fd72 into TypeStrong:master Jan 23, 2022
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jan 23, 2022

Thanks! Will be included in the next release, probably next weekend.

@williamkbentley williamkbentley mentioned this pull request Feb 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dayday10 Dayday10 Dayday10 approved these changes

@Gerrit0 Gerrit0 Awaiting requested review from Gerrit0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning on undocumented items
3 participants
@Nokel81 @Gerrit0 @Dayday10