Changed how index is loaded to improve performance #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JSON imports I believe will run into the same issue as using regular imports when browsing files locally (i.e. not in a web browser), so I think we'll probably want to avoid those unfortunately. LGTM once lint passes! |
dragomirtitian
force-pushed
the
feat-improve-index-loading-perf
branch
from
0112437
to
2767ae9
Compare
Gerrit0
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1825. Using
JSON.parseensures faster loading as the grammar for JSON is much simpler, so parsing JSON instead of JavaScript will be much faster (1s vs 7s in out use case)We could consider JSON imports at a later date when that proposal reaches stage 4.