Pretty print types in Default theme #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't looked too closely, but; can this flag be local to the type renderer, rather than global for potential misuse by other templates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced same issue as mentioned here - large types looks ugly because of no line wraps or indentation.
I offer an improvement for DefaultTheme that allows to render types as formatted tree using
DefaultThemeRenderContextas storage when recursively rendering nesting types.Example of working:
I think this feature should be controlled with some additional configuration options (at least, use this feature or no and indent spaces quantity), but I'm not sure about your policy of adding theme-related options.