Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✔️ name attribute added for select tag #2558

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Nil2000
Copy link

@Nil2000 Nil2000 commented Apr 27, 2024

This PR is with reference to #2557
Hope this resolves.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Apr 27, 2024

This doesn't appear to solve the issue, since there isn't any <label> with that name for it to reference... I think the right approach here is to use aria-labeledby to reference the header

@Nil2000
Copy link
Author

Nil2000 commented Apr 27, 2024

Hi, @Gerrit0 I introduced <label> and made it associated with the name in <select>. Can you verify if this is fine?

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Apr 27, 2024

MDN says that <label><h3> is a bad idea, it looks like the theme "label-heading" ought not be a header element, and just be a label to me... which probably means the same applies to the member visibility heading... slightly more involved here than I expected!

@Nil2000
Copy link
Author

Nil2000 commented Apr 27, 2024

Then it's better to use <label> and define a class having the same property of <h4>. I believe it's just the size that's require here.

Gerrit0 added a commit that referenced this pull request May 5, 2024
Closes #2558
Closes #2557

Co-Authored-By: Anonymus2000 <54113952+nil2000@users.noreply.github.com>
@Gerrit0
Copy link
Collaborator

Gerrit0 commented May 5, 2024

I manually merged this into the beta branch with 56f92c5, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants