Database schema / seed + other setup #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnywyatt
force-pushed
the
subscriptions
branch
from
dd6529b
to
a2ab828
Compare
jonnywyatt
force-pushed
the
subscriptions
branch
from
343b2ed
to
5c4652f
Compare
jonnywyatt
changed the title
bertrandmc
approved these changes
Apr 26, 2021
Dockerfile
Outdated
| RUN mkdir -p /usr/src/app | ||
| WORKDIR /usr/src/app | ||
| COPY package.json package-lock.json babel.config.json tsconfig.json ./ | ||
| COPY ./prisma ./prisma/ |
jonnywyatt
force-pushed
the
subscriptions
branch
2 times, most recently
from
b6f4702
to
275f902
Compare
jonnywyatt
force-pushed
the
subscriptions
branch
from
275f902
to
ca6ff8d
Compare
| CREATE UNIQUE INDEX "Subscription.recipientId_recipientIdPrefix_channelId_countryCode_unique" ON "Subscription"("recipientId", "recipientIdPrefix", "channelId", "countryCode"); | ||
|
|
||
| -- AddForeignKey | ||
| ALTER TABLE "Alert" ADD FOREIGN KEY ("staffId") REFERENCES "Staff"("id") ON DELETE CASCADE ON UPDATE CASCADE; |
There was a problem hiding this comment.
In order to preserve audit history, would it be better to soft-delete / change the status of a staff member to "departed" or "inactive" rather than hard-deleting them from the database and cascading the delete down to the referenced tables? Same would apply for the other FKs using ON DELETE CASCADE
There was a problem hiding this comment.
Good shout, I'll do that
There was a problem hiding this comment.
It looks like Prisma will add support for configuring cascading deletes via the schema, in the next release (early May) - prisma/prisma#2810
I'll hold this until then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup