Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Modal Dialog #176

Merged
merged 23 commits into from
May 23, 2024
Merged

feat: Add Modal Dialog #176

merged 23 commits into from
May 23, 2024

Conversation

UKHOGreg
Copy link
Contributor

@UKHOGreg UKHOGreg commented Mar 19, 2024 •
edited by github-actions bot

📦 Published PR as canary version: 0.14.0--canary.176.2e04e91.0

✨ Test out this PR locally via:

npm install @ukho/admiralty-angular@0.14.0--canary.176.2e04e91.0
npm install @ukho/admiralty-core@0.14.0--canary.176.2e04e91.0
# or 
yarn add @ukho/admiralty-angular@0.14.0--canary.176.2e04e91.0
yarn add @ukho/admiralty-core@0.14.0--canary.176.2e04e91.0

@UKHOGreg UKHOGreg self-assigned this Mar 19, 2024
@UKHOGreg UKHOGreg linked an issue Mar 19, 2024 that may be closed by this pull request
Create modal pop up including greyed out background #162
Closed
@UKHOGreg UKHOGreg added the enhancement New feature or request label Mar 19, 2024
@UKHOGreg UKHOGreg changed the title Add Modal Dialog feat: Add Modal Dialog Mar 19, 2024
@UKHOGreg UKHOGreg force-pushed the 162-create-modal-pop-up-including-greyed-out-background branch from 278eed3 to 9bdd077 Compare April 9, 2024 09:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-176.westeurope.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-176.westeurope.azurestaticapps.net

@UKHOGreg UKHOGreg force-pushed the 162-create-modal-pop-up-including-greyed-out-background branch from 1f98c7c to ed6bbec Compare April 22, 2024 11:52
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-176.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-176.westeurope.azurestaticapps.net

4 similar comments
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-176.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-176.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-176.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-176.westeurope.azurestaticapps.net

@UKHOGreg UKHOGreg marked this pull request as ready for review April 30, 2024 13:39
@UKHOGreg UKHOGreg requested a review from a team as a code owner April 30, 2024 13:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-176.westeurope.azurestaticapps.net

@UKHOGreg UKHOGreg force-pushed the 162-create-modal-pop-up-including-greyed-out-background branch from 156f507 to 07cc0fc Compare May 7, 2024 13:43
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-176.westeurope.azurestaticapps.net

@UKHOGreg UKHOGreg force-pushed the 162-create-modal-pop-up-including-greyed-out-background branch from a94154d to e05c2af Compare May 21, 2024 14:30
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-176.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-176.westeurope.azurestaticapps.net

@UKHOGreg @ecstaticrainbow
Fix Modal Dialog docs example to only show the Modal Dialog on button…
37a3049 
… click

Co-authored-by: TB <24593464+ecstaticrainbow@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-176.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-176.westeurope.azurestaticapps.net

@UKHOGreg UKHOGreg enabled auto-merge (squash) May 22, 2024 16:02
@UKHOGreg @ecstaticrainbow
Remove Hidden Modal Dialog docs example
08894fb 
Co-authored-by: TB <24593464+ecstaticrainbow@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-176.westeurope.azurestaticapps.net

ecstaticrainbow
ecstaticrainbow approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@ecstaticrainbow ecstaticrainbow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UKHOGreg UKHOGreg disabled auto-merge May 23, 2024 11:57
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-176.westeurope.azurestaticapps.net

@UKHOGreg UKHOGreg merged commit f3facb0 into main May 23, 2024
10 checks passed
@UKHOGreg UKHOGreg deleted the 162-create-modal-pop-up-including-greyed-out-background branch May 23, 2024 11:58
@github-actions GitHub Actions
Copy link
Contributor

🚀 PR was released in v0.14.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecstaticrainbow ecstaticrainbow ecstaticrainbow approved these changes

Assignees

@UKHOGreg UKHOGreg

Labels
enhancement New feature or request minor Increment the minor version when merged package: angular package: core package: react package: website released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create modal pop up including greyed out background
2 participants
@UKHOGreg @ecstaticrainbow