Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update chart.js to 3.9.1 #400

Closed
wants to merge 1 commit into from
Closed

Conversation

jxjj
Copy link
Contributor

@jxjj jxjj commented Aug 3, 2022

This updates chart.js to the latest release.

building can fail with the previous version of Chart.js:

ERROR in ./node_modules/chart.js/helpers/helpers.mjs 1:0-36
Module not found: Error: Can't resolve '../dist/helpers.esm' in '/home/runner/work/ChimeIn2.0/ChimeIn2.0/node_modules/chart.js/helpers'
Did you mean 'helpers.esm.js'?
BREAKING CHANGE: The request '../dist/helpers.esm' failed to resolve only because it was resolved as fully specified
(probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '*.mjs' file, or a '*.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.
Add the extension to the request.

See: chartjs/Chart.js#10552

@jxjj jxjj requested a review from cmcfadden August 3, 2022 20:33
@jxjj jxjj self-assigned this Aug 3, 2022
@cmcfadden
Copy link
Member

why did this just start breaking though?

@jxjj jxjj closed this Aug 4, 2022
@jxjj jxjj deleted the feature/update-chart-js-3.9.1 branch August 4, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants