Skip to content
This repository has been archived by the owner on Mar 15, 2024. It is now read-only.

Fixes 1594: Add batch status tab #1632

Merged
merged 8 commits into from Jun 21, 2023
Merged

Fixes 1594: Add batch status tab #1632

merged 8 commits into from Jun 21, 2023

Conversation

alaws-USGS
Copy link
Contributor

Closes #1594

Copy link
Member

@harper-wavra harper-wavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, very exciting!!

  • When I first click on Batch Status there is spinning loader that displays. I don't think we need a loader until after a user enters an email and it is retrieving information.
  • Maybe we could have the email textbox and the check status button on the same line.
  • If there are no results for a certain email, could we display a message maybe "No batches returned for the entered email." instead of an empty table?

Copy link
Member

@amedenblik amedenblik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same feedback as Harper!

One other thing: when I highlight the text in the email address box, the modal closes. Is there a way to fix this?

@amedenblik
Copy link
Member

Also just FYI the S3 links are no longer working for some reason, but it's not your fault. The bucket went missing on S3.

@alaws-USGS
Copy link
Contributor Author

alaws-USGS commented Jun 21, 2023

Requested updates:

  • Spinning loader after submit is clicked
  • Email textbox and button on same line
  • Display a message "No batches returned for the entered email" when nothing returned
  • When text is highlighted in the email address box, the modal closes. Is there a way to fix this?

@alaws-USGS
Copy link
Contributor Author

@amedenblik this appears to be an issue with the underlying bootstrap version twbs/bootstrap#36745

When I click and drag but stay within the modal, the modal window does not collapse.

Copy link
Member

@amedenblik amedenblik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Can we actually put the Email address text, input box, and button on the same line? You may need to fiddle with the HTML/CSS to add some extra space between the input box and button and make it so they are aligned nicely

Quick Powerpoint mockup:
image

Copy link
Member

@amedenblik amedenblik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

Copy link
Member

@harper-wavra harper-wavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@harper-wavra harper-wavra merged commit 7b8e9a9 into batch-processor Jun 21, 2023
@harper-wavra harper-wavra deleted the arl-1594 branch June 21, 2023 20:32
@harper-wavra
Copy link
Member

Dev site updated: https://dev.streamstats.usgs.gov/bp/.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants