move to grunt-browserify, with fix for node tcp shim #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevj
force-pushed
the
trevj-grunt-browserify-5.0
branch
from
55b6628
to
49de614
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little code health exercise: move to grunt-browserify 5.x.
This revision is based on browserify 13 - the only incompatibility I've seen is that
toArrayBufferwas removed; however, since Buffer now implements the Uint8Array interface I was able to just access its buffer field which is probably a little faster:https://github.com/substack/node-browserify/blob/master/changelog.markdown#1300
BTW, some background on why they removed that method:
nodejs/node-v0.x-archive#7609 (comment)
This change is