Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolving coded types while typing in ETB STUD-69826 #319

Conversation

gabrielavaduva
Copy link
Collaborator

@gabrielavaduva gabrielavaduva commented Apr 29, 2024

This resolves the issue where typing in an expressionTextbox expecting a return type of a type with a generic argument type comes from an assembly that is in another ALC, than his parent.
E.g. List as a returnType in an expressionTextbox, it would fail, as reflection cannot resolve at-once a type from string, if atleast one of its children come from another ALC, so we resolve type-by-type and compose the resulting type in the end.

Jira

https://uipath.atlassian.net/browse/STUD-69826

Copy link
Collaborator

@aoltean16 aoltean16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link the jira issue, and let's see what the actual problem is, as it is not clear from the unit tests

src/Test/TestCases.Workflows/ExpressionTests.cs Outdated Show resolved Hide resolved
src/UiPath.Workflow/Activities/ExpressionCompiler.cs Outdated Show resolved Hide resolved
@aoltean16 aoltean16 self-requested a review May 15, 2024 15:13
@aoltean16 aoltean16 force-pushed the fix/generic_types_with_type_from_other_assemblies_not_resolved branch from d2e9a9d to f721cd6 Compare May 15, 2024 15:14
@aoltean16 aoltean16 changed the title Fix resolving generic types Fix resolving coded types while typing in ETB STUD-69826 May 15, 2024
@aoltean16 aoltean16 merged commit f8c9569 into develop May 15, 2024
2 checks passed
@aoltean16 aoltean16 deleted the fix/generic_types_with_type_from_other_assemblies_not_resolved branch May 15, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants