Added an IME input sample scene #1769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyndon-unity
reviewed
Oct 6, 2023
| } | ||
|
|
||
| // Ensures all fields are correctly referenced | ||
| private void AssertInvariance() |
There was a problem hiding this comment.
Strange naming but I like the check
There was a problem hiding this comment.
I agree actually, maybe EnsureReferencesNotNull or something like that would be clearer. Will get this switched out today.
lyndon-unity
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have had a select few bugs around IME input recently and I thought it would be a good idea to have a sample scene which doubles up as an example of how to handle IME input.
It isn't absolutely perfect since it doesn't handle everything perfectly, but it is a barebones scene that can be built on top of. Will be useful for us for testing IME related issues as well as customers to have a starting point when implementing IME input.
Changes made