Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Invaders to use Netcode For Gameobject 1.8.1 [MTT-8503] #172

Merged
merged 9 commits into from
May 29, 2024
Merged

Upgrade Invaders to use Netcode For Gameobject 1.8.1 [MTT-8503] #172

merged 9 commits into from
May 29, 2024

Conversation

bastienunity
Copy link
Contributor

Description

  • Upgraded NGO to 1.8.1
  • Changed usage of ClientRPC and ServerRPC to the unified RPCAttribute.
  • Changed OnClientConnectedCallback registration to use the new OnConnectionEvent.
  • Changing spawn methods to use InstantiateAndSpawn.

Issue Number(s)

MTT-8503 Upgrade Invaders to use Netcode For Gameobject 1.8.1 and changed code to new recommended API.

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@bastienunity bastienunity marked this pull request as ready for review May 6, 2024 18:28
@bastienunity bastienunity requested a review from a team as a code owner May 6, 2024 18:28
fernando-cortez
fernando-cortez reviewed May 6, 2024
View reviewed changes
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicks on Rpc names!

Basic/Invaders/Assets/Scripts/PlayerControl.cs Outdated Show resolved Hide resolved
RikuTheFuffs
RikuTheFuffs previously requested changes May 20, 2024
View reviewed changes
Basic/Invaders/Assets/Scripts/EnemyBullet.cs Show resolved Hide resolved
Basic/Invaders/Assets/Scripts/InvadersGame.cs Show resolved Hide resolved
Basic/Invaders/Assets/Scripts/InvadersGame.cs Show resolved Hide resolved
Basic/Invaders/Assets/Scripts/LobbyControl.cs Show resolved Hide resolved
Basic/Invaders/Assets/Scripts/LobbyControl.cs Show resolved Hide resolved
Basic/Invaders/Assets/Scripts/LobbyControl.cs Show resolved Hide resolved
Basic/Invaders/Assets/Scripts/LobbyControl.cs Show resolved Hide resolved
Basic/Invaders/Assets/Scripts/PlayerBullet.cs Show resolved Hide resolved
Basic/Invaders/Assets/Scripts/PlayerControl.cs Show resolved Hide resolved
Basic/Invaders/Assets/Scripts/PlayerControl.cs Show resolved Hide resolved
@RikuTheFuffs RikuTheFuffs self-requested a review May 29, 2024 07:59
@fernando-cortez fernando-cortez dismissed RikuTheFuffs’s stale review May 29, 2024 19:00

Unblocking PR, and re-approving!

@fernando-cortez fernando-cortez merged commit 36e240b into develop May 29, 2024
19 checks passed
@fernando-cortez fernando-cortez deleted the feature/invaders-ngo-1.8.1 branch May 29, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@Elfi0Kuhndorf Elfi0Kuhndorf Awaiting requested review from Elfi0Kuhndorf

@RikuTheFuffs RikuTheFuffs Awaiting requested review from RikuTheFuffs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bastienunity @RikuTheFuffs @fernando-cortez @Elfi0Kuhndorf