Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Multiplayer Use cases to NGO 1.8.1 [MTT-8499] #178

Merged
merged 9 commits into from
May 28, 2024
Merged

Upgrade Multiplayer Use cases to NGO 1.8.1 [MTT-8499] #178

merged 9 commits into from
May 28, 2024

Conversation

Elfi0Kuhndorf
Copy link
Contributor

@Elfi0Kuhndorf Elfi0Kuhndorf commented May 15, 2024 •
edited

Description

PR for upgrading NGO to package V1.8.1. This includes adjusting scripts for implementing new API.
Includes:

  • New RPC attributes
  • OnConnectionEvent

Validation:
Check if scenes work as expected.

Issue Number(s)

MTT-8499

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@Elfi0Kuhndorf Elfi0Kuhndorf added the enhancement New feature or request label May 15, 2024
@Elfi0Kuhndorf Elfi0Kuhndorf self-assigned this May 15, 2024
@Elfi0Kuhndorf Elfi0Kuhndorf changed the base branch from main to develop May 15, 2024 15:43
@Elfi0Kuhndorf Elfi0Kuhndorf marked this pull request as ready for review May 16, 2024 12:17
@Elfi0Kuhndorf Elfi0Kuhndorf requested a review from a team as a code owner May 16, 2024 12:17
fernando-cortez
fernando-cortez reviewed May 17, 2024
View reviewed changes
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small potential refactors!

Experimental/MultiplayerUseCases/Packages/manifest.json Show resolved Hide resolved
Experimental/MultiplayerUseCases/Assets/Common/Scripts/GameUI.cs Show resolved Hide resolved
Experimental/MultiplayerUseCases/Assets/Common/Scripts/GameUI.cs Outdated Show resolved Hide resolved
Experimental/MultiplayerUseCases/Assets/UseCaseSamples/NetvarVsRpc/Scripts/ColorManager.cs Show resolved Hide resolved
Experimental/MultiplayerUseCases/Assets/UseCaseSamples/NetvarVsRpc/Scripts/ColorManager.cs Show resolved Hide resolved
Experimental/MultiplayerUseCases/Assets/UseCaseSamples/NetvarVsRpc/Scripts/ColorManager.cs Outdated Show resolved Hide resolved
@Elfi0Kuhndorf
adjusted scripts to address comments
426a7dc 
fixing PascalCase in Rpcs, removing empty Line and naming refactor
change version numbers in readme file
RikuTheFuffs
RikuTheFuffs requested changes May 23, 2024
View reviewed changes
Experimental/MultiplayerUseCases/Assets/UseCaseSamples/NetvarVsRpc/Scripts/ColorManager.cs Show resolved Hide resolved
Experimental/MultiplayerUseCases/Assets/UseCaseSamples/NetvarVsRpc/Scripts/ColorManager.cs Show resolved Hide resolved
Experimental/MultiplayerUseCases/Assets/UseCaseSamples/NetvarVsRpc/Scripts/ColorManager.cs Show resolved Hide resolved
Experimental/MultiplayerUseCases/Assets/UseCaseSamples/ProximityChecks/Scripts/ColorManager.cs Show resolved Hide resolved
Experimental/MultiplayerUseCases/Assets/UseCaseSamples/RPCs/Scripts/MoodManager.cs Show resolved Hide resolved
Experimental/MultiplayerUseCases/Assets/UseCaseSamples/RPCs/Scripts/MoodManager.cs Show resolved Hide resolved
Experimental/MultiplayerUseCases/Assets/Common/Scripts/GameUI.cs Outdated Show resolved Hide resolved
@Elfi0Kuhndorf Elfi0Kuhndorf merged commit e8fa6ed into develop May 28, 2024
19 checks passed
@Elfi0Kuhndorf Elfi0Kuhndorf deleted the feature/upgrade-multiplayerusecases-ngo-1.8.1 branch May 28, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RikuTheFuffs RikuTheFuffs RikuTheFuffs approved these changes

@bastienunity bastienunity Awaiting requested review from bastienunity

@fernando-cortez fernando-cortez Awaiting requested review from fernando-cortez

Assignees

@Elfi0Kuhndorf Elfi0Kuhndorf

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Elfi0Kuhndorf @RikuTheFuffs @fernando-cortez