fix(lint): run lint-staged on pre-commit again #594

theneva · 2024-02-22T10:25:50Z

Hi! 👋

This PR is based on #593, so please ignore the first commit.

Husky dropped support for the hooks field in package.json in v5, so the pre-commit hook (and, by extension lint-staged) has not been run since Husky was upgraded from v4 to v7 in 2021 (fcf3c18).

I also made ESLint actually run Prettier by extending the prettier/recommended config.

theneva · 2024-02-22T10:32:51Z

.eslintrc

@@ -1,11 +1,9 @@
 {
  "extends": [
-    "airbnb-typescript/base",


prettier does pretty much all that airbnb-typescript does, so there's no real need for both of them

you probably need the parser etc? line 10 and down https://www.npmjs.com/package/eslint-config-airbnb-typescript?activeTab=code

you're absolutely right. I tested locally with a file with no typescript-specific keywords… I just added eslint-config-airbnb-typescript back in now

theneva · 2024-02-22T10:34:15Z

.eslintrc

    "plugin:import/recommended",
-    "plugin:import/typescript"
+    "plugin:import/typescript",
+    "plugin:prettier/recommended"


From https://github.com/prettier/eslint-plugin-prettier#configuration-legacy-eslintrc:

This will:

Enable the prettier/prettier rule.

Disable the arrow-body-style and prefer-arrow-callback rules which are problematic with this plugin - see the below for why.

Enable the eslint-config-prettier config which will turn off ESLint rules that conflict with Prettier.

theneva · 2024-02-22T10:34:31Z

.eslintrc

  ],
-  "plugins": ["prettier"],


extending plugin:prettier/recommended does this

theneva · 2024-02-22T10:35:07Z

package.json

@@ -116,18 +115,13 @@
    ]
  },
  "lint-staged": {
-    "*.js": [
+    "*.{js,ts}": [


ESLint didn't support TypeScript when this was first added in 2018, but it does now!

theneva · 2024-02-22T10:35:49Z

package.json

-  "husky": {
-    "hooks": {
-      "pre-commit": "lint-staged"
-    }
-  },


this configuration style was dropped in Husky v5, which is why it stopped working. The hooks are now configured as separate files in .husky/

theneva · 2024-02-22T10:36:59Z

.husky/pre-commit

@@ -0,0 +1 @@
+yarn run pre-commit


This is the configuration style Husky has used since v5, so this file replaces the hooks.pre-commit property in package.json

theneva · 2024-02-22T10:37:33Z

package.json

    "prebuild": "del-cli --force lib",
    "build": "tsc -p .",
-    "prepare": "yarn run build",
+    "prepare": "husky && yarn run build",


This installs the hooks in .husky/… into .git/hooks/…

theneva · 2024-02-22T10:38:27Z

package.json

    "eslint-config-prettier": "^8.8.0",
    "eslint-import-resolver-typescript": "^3.5.5",
    "eslint-plugin-import": "^2.27.5",
    "eslint-plugin-prettier": "^5.0.0",
    "esm": "^3.2.25",
-    "husky": "^8.0.3",
+    "husky": "^9.0.11",


~~I figured I'd bump Husky to the latest v9 since I was touching it anyway – but the changes in this PR should work fine with v8 too~~ Husky v9 dropped support for Node 16, so I kept it at v8

coveralls · 2024-02-22T10:46:30Z

coverage: 90.863%. remained the same
when pulling 1418940 on theneva:fix-lint-staged
into 59b82c5 on Unleash:main.

… stuff

gastonfournier

This looks great @theneva! In Unleash we switched to biome which is faster, but we believe this is great anyway and don't have a strong attachment to biome. I'd say we go ahead with this one! Thanks for the contribution!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [unleash-client](https://togithub.com/Unleash/unleash-client-node) | [`5.5.1` -> `5.5.2`](https://renovatebot.com/diffs/npm/unleash-client/5.5.1/5.5.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/unleash-client/5.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/unleash-client/5.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/unleash-client/5.5.1/5.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/unleash-client/5.5.1/5.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Unleash/unleash-client-node (unleash-client)</summary> ### [`v5.5.2`](https://togithub.com/Unleash/unleash-client-node/releases/tag/v5.5.2) [Compare Source](https://togithub.com/Unleash/unleash-client-node/compare/v5.5.1...v5.5.2) #### What's Changed - chore(deps): update dependency nock to v13.5.3 by [@renovate](https://togithub.com/renovate) in [https://github.com/Unleash/unleash-client-node/pull/588](https://togithub.com/Unleash/unleash-client-node/pull/588) - fix(lint): run lint-staged on pre-commit again by [@theneva](https://togithub.com/theneva) in [https://github.com/Unleash/unleash-client-node/pull/594](https://togithub.com/Unleash/unleash-client-node/pull/594) - fix: add ip to resolutions by [@gastonfournier](https://togithub.com/gastonfournier) in [https://github.com/Unleash/unleash-client-node/pull/601](https://togithub.com/Unleash/unleash-client-node/pull/601) #### New Contributors - [@theneva](https://togithub.com/theneva) made their first contribution in [https://github.com/Unleash/unleash-client-node/pull/594](https://togithub.com/Unleash/unleash-client-node/pull/594) **Full Changelog**: Unleash/unleash-client-node@v5.5.1...v5.5.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 7pm every weekday,before 5am every weekday" in timezone Europe/Madrid, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Unleash/unleash).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

theneva added 2 commits February 22, 2024 09:23

chore: run lint:fix

Loading
Loading status checks…

edb338c

fix(eslint): run lint-staged on pre-commit again

Loading
Loading status checks…

45b25ce

theneva changed the title ~~chore: run lint:fix~~ fix(eslint): run lint-staged on pre-commit again Feb 22, 2024

theneva changed the title ~~fix(eslint): run lint-staged on pre-commit again~~ fix(lint): run lint-staged on pre-commit again Feb 22, 2024

theneva commented Feb 22, 2024

View reviewed changes

theneva mentioned this pull request Feb 22, 2024

chore: run lint:fix #593

Closed

theneva added 3 commits February 22, 2024 11:53

don't run prettier manually on lint:fix

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

a531fe0

downgrade husky to v8 since v9 dropped support for Node 16

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

Loading
Loading status checks…

1418940

gastonfournier approved these changes Feb 23, 2024

View reviewed changes

thomasheartman merged commit 17de2d6 into Unleash:main Mar 5, 2024
4 checks passed

theneva deleted the fix-lint-staged branch March 6, 2024 09:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(lint): run lint-staged on pre-commit again #594

fix(lint): run lint-staged on pre-commit again #594

theneva commented Feb 22, 2024 •

edited

Loading

theneva Feb 22, 2024

SimenB Feb 22, 2024

theneva Feb 22, 2024

theneva Feb 22, 2024

theneva Feb 22, 2024

theneva Feb 22, 2024

theneva Feb 22, 2024

theneva Feb 22, 2024

theneva Feb 22, 2024 •

edited

Loading

theneva Feb 22, 2024 •

edited

Loading

coveralls commented Feb 22, 2024 •

edited

Loading

gastonfournier left a comment

fix(lint): run lint-staged on pre-commit again #594

fix(lint): run lint-staged on pre-commit again #594

Conversation

theneva commented Feb 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theneva Feb 22, 2024 • edited Loading

Choose a reason for hiding this comment

theneva Feb 22, 2024 • edited Loading

Choose a reason for hiding this comment

coveralls commented Feb 22, 2024 • edited Loading

gastonfournier left a comment

Choose a reason for hiding this comment

theneva commented Feb 22, 2024 •

edited

Loading

theneva Feb 22, 2024 •

edited

Loading

theneva Feb 22, 2024 •

edited

Loading

coveralls commented Feb 22, 2024 •

edited

Loading