Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support regular evaluations via POST #106

Merged
merged 4 commits into from
Dec 5, 2022
Merged

Conversation

ivarconr
Copy link
Member

@ivarconr ivarconr commented Nov 29, 2022

This PR extends the POST endpoint for fetching feature toggle configurations to also support empty list of feature toggle names, which basically makes POST work the same way as a regular GET request.

POST https://url/proxy
body: {"context": "{"appName": "test"}}

Needed for Unleash/unleash-proxy-client-js#125

Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivarconr ivarconr merged commit 484a493 into main Dec 5, 2022
@ivarconr ivarconr deleted the feat/POST-fetching branch December 5, 2022 10:14
@LukasHeimann
Copy link

Looks like this sidesteps the ContextEnrichers introduced with #87...

@ivarconr
Copy link
Member Author

ivarconr commented Dec 7, 2022

Looks like this sidesteps the ContextEnrichers introduced with #87...

That's absolutely true, thanks for raising this!
It seems to be a lot of similar code dealing with HTTP request. I think we need a separate cleanup task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants