feat: expose lifecycle stage in project overview search #7017
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| featureSearchStore: new FeatureSearchStore( | ||
| db, | ||
| eventBus, | ||
| getLogger, | ||
| config.flagResolver, | ||
| ), |
There was a problem hiding this comment.
❌ Getting worse: Large Method
createStores increases from 106 to 112 lines of code, threshold = 70
| @@ -224,6 +253,14 @@ class FeatureSearchStore implements IFeatureSearchStore { | |||
| ); | |||
| }); | |||
|
|
|||
| if (featureLifecycleEnabled) { | |||
| query.leftJoin( | |||
There was a problem hiding this comment.
I would not join it into original query, but rather into final query, where the paging has been done already.
| @@ -86,6 +95,19 @@ class FeatureSearchStore implements IFeatureSearchStore { | |||
| const validatedSortOrder = | |||
| sortOrder === 'asc' || sortOrder === 'desc' ? sortOrder : 'asc'; | |||
|
|
|||
| const featureLifecycleEnabled = | |||
| this.flagResolver.isEnabled('featureLifecycle'); | |||
| const latestLifecycleStageQuery = this.db | |||
There was a problem hiding this comment.
Also can we look into opportunities to pull it out as a method, and put all selects, joins and query there
| const featureLifecycleEnabled = | ||
| this.flagResolver.isEnabled('featureLifecycle'); | ||
|
|
There was a problem hiding this comment.
❌ Getting worse: Complex Method
FeatureSearchStore.searchFeatures increases in cyclomatic complexity from 11 to 12, threshold = 9
| getAggregatedSearchData( | ||
| rows, | ||
| featureLifecycleEnabled: boolean, | ||
| ): IFeatureSearchOverview[] { |
There was a problem hiding this comment.
❌ Getting worse: Complex Method
FeatureSearchStore.getAggregatedSearchData increases in cyclomatic complexity from 9 to 11, threshold = 9
About the changes
Each feature in project overview search will have a lifecycle with current stage and entered date similarly to single feature query.
I'm adding this new capability behind a flag so that we can safely roll it out.
Important files
Discussion points