New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for disabling scrollIntoView #87

Open

chestermjr wants to merge 1 commit into master from chestermillisock/ngc-omnibox-shouldscroll-2

Contributor

chestermjr commented Dec 26, 2019

I recently added a PR for adding support for disabling scrollIntoView functionality. This PR adds unit tests. I also did a small refactor:

Previously, at the beginning of the _scrollSuggestionIntoView function, I returned early when shouldScrollIntoView property was false.
Now, instead, I am not calling _scrollSuggestionIntoView when shouldScrollIntoView property is false.


          Unit tests for disabling scrollIntoView

4e8f821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment