Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finder method solution #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Finder method solution #33

wants to merge 2 commits into from

Conversation

lamasgergo
Copy link

jadb
jadb reviewed Nov 4, 2016
View reviewed changes
src/Model/Behavior/TagBehavior.php
'implementedEvents' => [
'Model.beforeMarshal' => 'beforeMarshal',
'Model.beforeMarshal' => 'beforeMarshal'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the commas please.

@jadb
Copy link
Member

jadb commented Nov 4, 2016

Thanks! And sorry for the delay.

Mind adding some tests?

@dereuromark
Copy link

I implemented this in the new tags repo @ https://github.com/dereuromark/cakephp-tags
You have to return the query for it to work, somehow this must have changed over the last versions of CakePHP. Took me a while to figure it out and adding a passing test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jadb jadb jadb left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lamasgergo @jadb @dereuromark