Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): playwright to 1.34.3 #5119

Merged
merged 1 commit into from May 30, 2023

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented May 22, 2023

Update playwright to 1.34.3

Cannot find module '@playwright/test'

yarn remove playwright (by release notes)

Missing libraries: libgudev-1.0.so.0

Workaround: apt update && apt install libgudev-1.0-0 -y


  • update screenshots

@SevereCloud SevereCloud force-pushed the SevereCloud/build/deps-dev/playwright-to-1.34.0 branch from 2f120ea to e2f56a6 Compare May 22, 2023 07:13
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 22, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 158c655:

Sandbox Source
VKUI TypeScript Configuration

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06 🎉

Comparison is base (056aac0) 81.67% compared to head (158c655) 81.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5119      +/-   ##
==========================================
+ Coverage   81.67%   81.73%   +0.06%     
==========================================
  Files         281      281              
  Lines        9428     9428              
  Branches     2993     2993              
==========================================
+ Hits         7700     7706       +6     
+ Misses       1728     1722       -6     
Flag Coverage Δ
a11ytests 8.64% <ø> (?)
unittests 81.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023

size-limit report 📦

Path Size
JS 303.13 KB (0%)
JS (gzip) 88.97 KB (0%)
JS (brotli) 73.86 KB (0%)
JS import Div (tree shaking) 2.97 KB (0%)
CSS 271.56 KB (0%)
CSS (gzip) 35.4 KB (0%)
CSS (brotli) 28.04 KB (0%)

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023

👀 Docs deployed

Commit 158c655

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023

e2e tests

Playwright Report

@SevereCloud SevereCloud force-pushed the SevereCloud/build/deps-dev/playwright-to-1.34.0 branch from e2f56a6 to 7750f62 Compare May 22, 2023 07:43
@SevereCloud SevereCloud self-assigned this May 22, 2023
@SevereCloud SevereCloud added the dependencies Pull requests that update a dependency file label May 22, 2023
@SevereCloud SevereCloud marked this pull request as ready for review May 22, 2023 07:44
@SevereCloud SevereCloud requested a review from a team as a code owner May 22, 2023 07:44
SevereCloud added a commit that referenced this pull request May 22, 2023
@SevereCloud SevereCloud mentioned this pull request May 22, 2023
@SevereCloud SevereCloud force-pushed the SevereCloud/build/deps-dev/playwright-to-1.34.0 branch from 7750f62 to 7358acb Compare May 22, 2023 11:39
SevereCloud added a commit that referenced this pull request May 22, 2023
inomdzhon
inomdzhon previously approved these changes May 22, 2023
BlackySoul
BlackySoul previously approved these changes May 29, 2023
@BlackySoul BlackySoul dismissed their stale review May 29, 2023 07:06

Merge conflict

@SevereCloud SevereCloud force-pushed the SevereCloud/build/deps-dev/playwright-to-1.34.0 branch from 7358acb to 158c655 Compare May 30, 2023 09:19
@inomdzhon inomdzhon changed the title build(deps-dev): playwright to 1.34.0 build(deps-dev): playwright to 1.34.3 May 30, 2023
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Залей в PR #5120 ветку плиз для теста

@SevereCloud
Copy link
Contributor Author

Залей в PR #5120 ветку плиз для теста

Влил

@SevereCloud SevereCloud merged commit 8305fa4 into master May 30, 2023
14 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/build/deps-dev/playwright-to-1.34.0 branch May 30, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file technical task
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants