辞書保存ダイアログ・ツールバーカスタマイズの編集破棄の案内がわかりにくかったので修正 #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
commented
May 8, 2024
| @@ -559,7 +559,7 @@ const isDeletable = computed(() => !!selectedId.value); | |||
| const deleteWord = async () => { | |||
| const result = await store.dispatch("SHOW_WARNING_DIALOG", { | |||
| title: "登録された単語を削除しますか？", | |||
| message: "削除された単語は復旧できません。", | |||
| message: "削除された単語は元に戻せません。", | |||
|
レビューありがとうございます！！ マージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
「単語の追加・変更を破棄しますか？このまま続行すると、単語の追加・変更は破棄されてリセットされます。」という文言に対し「キャンセル」「続行」となってた。
続行が何を示すのかわからなかったので案内を変更しました。
あと「このまま」という代名詞で分かりにくいので条件を崩しました。
その他