Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: テキスト読み込みでルビ文字列を削除 #2084

Merged
merged 2 commits into from
May 20, 2024

Conversation

weweweok
Copy link
Contributor

内容

関連 Issue

スクリーンショット・動画など

vokoscreenNG-2024-05-16_22-31-07.mp4

その他

テキストを無視する処理は、audio_queryや、accent_phrasesを生成する処理の直前に行った方が、記述ミスが減りそうな気がしました。

voicevox/src/store/audio.ts

Lines 958 to 963 in 4c9550b

.then((instance) =>
instance.invoke("audioQueryAudioQueryPost")({
text,
speaker: styleId,
}),
)

@weweweok weweweok requested a review from a team as a code owner May 16, 2024 13:50
@weweweok weweweok requested review from Hiroshiba and removed request for a team May 16, 2024 13:50
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

実装ありがとうございます!!!助かりました!!

テキストを無視する処理は、audio_queryや、accent_phrasesを生成する処理の直前に行った方が、記述ミスが減りそうな気がしました。

良さそうに思います!
場所によっては無視しない方がいい気もするので、変換を行うかの引数を作るのとかどうでしょうか?

@Hiroshiba Hiroshiba merged commit e5e6120 into VOICEVOX:main May 20, 2024
9 checks passed
@weweweok
Copy link
Contributor Author

それで恐らく良いと思うので

に共有させて頂きます。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants