New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron16かつLinuxだとshowOpenDialogSync、showSaveDialogSyncが動作しないので非同期版に置き換え #512
Merged
Hiroshiba
merged 108 commits into
VOICEVOX:main
from
madosuki:fix_failed_open_dialog_on_linux
Nov 26, 2021
Merged
Electron16かつLinuxだとshowOpenDialogSync、showSaveDialogSyncが動作しないので非同期版に置き換え #512
Hiroshiba
merged 108 commits into
VOICEVOX:main
from
madosuki:fix_failed_open_dialog_on_linux
Nov 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chModeItemClicked
This reverts commit 99b1def.
Hiroshiba
approved these changes
Nov 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
発見&プルリクエストありがとうございます!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Electron 14以降で発生している問題ぽいです。
関連 Issue
ref electron/electron#31997
ref electron/electron#31152
スクリーンショット・動画など
その他