Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron16かつLinuxだとshowOpenDialogSync、showSaveDialogSyncが動作しないので非同期版に置き換え #512

Merged
merged 108 commits into from Nov 26, 2021

Conversation

madosuki
Copy link
Contributor

内容

Electron 14以降で発生している問題ぽいです。

関連 Issue

ref electron/electron#31997
ref electron/electron#31152

スクリーンショット・動画など

その他

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

発見&プルリクエストありがとうございます!

@Hiroshiba Hiroshiba merged commit 6445201 into VOICEVOX:main Nov 26, 2021
@madosuki madosuki deleted the fix_failed_open_dialog_on_linux branch February 23, 2022 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants