Improving regexs that scan attributes #836
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently a check failed but @LarsAsplund you have already fixed it in #835 |
|
@std-max Yes, the latest version of Sphinx is a new major version and comes with some backward compatibility breaking changes which I fixed. That is shortly on the master branch and then you can rebase. |
|
CI looks good after rebasing :) |
|
@std-max do you mind adding some test to make this fix is necessary? I.e., the test should fail without this commit, but pass with it. |
|
Yes, I will add some tests when I have a bit of time 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #670