Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues when trying to parameterize Verilog modules #945

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

piotrva
Copy link

@piotrva piotrva commented Jul 12, 2023

This fixes #944 by trying to execute an original version (case-insensitive for VHDL compatibility) with the fall-back for use with Verilog and non-lower-case module names.

…format to fix issue with Verilog being case-sensitive.
@piotrva
Copy link
Author

piotrva commented Jul 28, 2023

Hi, any chance for having someone look at this PR?
We use VUnit in our company and for now we had to switch to my unofficial branch.

@oscargus
Copy link
Contributor

oscargus commented Sep 9, 2023

I think it maybe is better to either:

  1. Move the case-handling to get_test_bench
  2. Do try-except on get_test_bench only and then only check KeyError.

@piotrva
Copy link
Author

piotrva commented Oct 5, 2023

@oscargus I modified it as you suggested.

@oscargus
Copy link
Contributor

oscargus commented Oct 6, 2023

Thanks! (I should probably have mentioned that I cannot approve or merge anything, but I think/hope that the suggested changes increases the chance of having it merged...)

@piotrva
Copy link
Author

piotrva commented Oct 6, 2023

Can you possibly contact someone who is in charge of such approvals?
This issue is preventing us for use of official VUnit repo in our workflow what is suboptimal at least...

@oscargus
Copy link
Contributor

oscargus commented Oct 6, 2023

I can try to ping in @LarsAsplund and @kraigher . My impression is that they have been quite busy recently though. (There may be other people that have the correct powers as well.)

@piotrva
Copy link
Author

piotrva commented Dec 25, 2023

Any chance to have this fix merged any time soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to parameterize a Verilog module that name is not lower-case causes error.
2 participants