Use the compilation trigger to determine whether CSS injection should happen instead of emitted asset names. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… happen instead of emitted asset names.
|
Tested and works. My setup uses |
|
I cannot seem to get this working. Can you please share your config? |
|
@Brendonwbrown It might be better to see an example of where it isn't working for you. |
|
@Va1 any thoughts on this? =) |
|
any updates? |
lisunovdv
approved these changes
Oct 24, 2019
|
can someone verify this works and, if it does, that it does on all webpack major versions available? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion on #78 , I've created this. It might be worth deleting lib/getCssOnlyEmittedAssetsNames.js since I've removed the one call to it's method, but I wasn't sure if that was my place on this adjustment.
I also created an option that defaults to scss/sass/less/css as the regular expression for comparison against the compilation trigger.