new plugin YoutubeDescription #2427
Open
+54
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
I would personally prefer having it unexpanded by default, showing the first line, and then being able to click to show the rest. |
|
W |
|
@Cynosphere added |
|
|
Vendicated
reviewed
May 11, 2024
| return !isNonNullish(embed.rawDescription) | ||
| ? null | ||
| : embed.rawDescription.length > 20 | ||
| ? <div |
There was a problem hiding this comment.
this nested ternary isn't too great.. it'd be way nicer for readability to convert it into simple if statements, like
if (!embed.rawDescription)
return null;
if (embed.rawDescription.length <= 20)
return original();
return (
<div>
....
Vendicated
reviewed
May 11, 2024
| } | ||
| } | ||
| ], | ||
| ToggleableDescription({ embed, original }: ToggleableDescriptionProps) { |
There was a problem hiding this comment.
this should be wrapped in an ErrorBoundary, then you also wouldn't need your Wrapper function
Suggested change
| ToggleableDescription({ embed, original }: ToggleableDescriptionProps) { | |
| ToggleableDescription: ErrorBoundary.wrap(({ embed, original }: ToggleableDescriptionProps) => { |
Vendicated
reviewed
May 11, 2024
| ToggleableDescription({ embed, original }: ToggleableDescriptionProps) { | ||
| const [isOpen, setOpen] = useState(false); | ||
|
|
||
| console.warn(embed); |
There was a problem hiding this comment.
please remove this console.log
Suggested change
| console.warn(embed); |
|
maybe an improvement to the collapsing could be to collapse on the first newline instead of just after some characters? with a sanity limit of like 200 characters or something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds descriptions to youtube video embeds