Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamagg native histogram support #6057

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

hardproblems
Copy link

@hardproblems hardproblems commented Apr 2, 2024

Draft PR for #3733

Note: this PR contains commits from other pending PRs but wanted to open this for some early feedback.

@hagen1778 @valyala @edma2

@hardproblems hardproblems marked this pull request as ready for review April 3, 2024 06:29
@hardproblems hardproblems force-pushed the native-histogram-streamaggr branch 8 times, most recently from f72f84e to c7d55e9 Compare April 18, 2024 21:04
@hardproblems
Copy link
Author

ping @valyala @AndrewChubatiuk @hagen1778

@hardproblems hardproblems force-pushed the native-histogram-streamaggr branch 3 times, most recently from c5f5ef7 to 64297bf Compare April 29, 2024 23:25
…unction

add MarshalToSizedBuffer and Size methods for Histogram types

don't lump histogram and rows total together

fix unit tests

bug fix

Compact before flush

validate and log; better histogram reset detection

switch to info logging for histogram reset

fix metrics
@f41gh7
Copy link
Contributor

f41gh7 commented May 9, 2024

Hello, at first we're going to merge the following PR #5855

It adds support for protobuf encoded prometheus metrics format. It currently blocks this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants