Exemplar support for Cluster #6135
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ted Possible <ted_possible@cable.comcast.com>
Added Exemplars to marshaling/unmarshaling processes Signed-off-by: Ted Possible <ted_possible@cable.comcast.com>
Added Exemplars to addRowToTimeSeries (scrapework) Signed-off-by: Ted Possible <ted_possible@cable.comcast.com>
- didn't work when there was no tags - didn't work when there was whitespace between metric name and tag start Added OpenMetrics Header for Exemplars to the client Improved tests for Exemplars Added Exemplars to PendingSeries tests and modified sizes to accomdoate exemplars In scrapework improved to only add exemplars if they exist. Signed-off-by: Ted Possible <ted_possible@cable.comcast.com>
Signed-off-by: Ted Possible <ted_possible@cable.comcast.com>
Signed-off-by: Ted Possible <ted_possible@cable.comcast.com>
…of allocs Fixed performance issues with row.unmarshal Signed-off-by: Ted Possible <ted_possible@cable.comcast.com>
Refactored and Optimized tag parsing utilzing tagsPool storage
Bugfixes for white space at the end of exemplar
Added passing test case for missing spaces between # and { for exemplar
Signed-off-by: Ted Possible <ted_possible@cable.comcast.com>
Signed-off-by: Ted Possible <ted_possible@cable.comcast.com>
Numerous format fixes - comments Optimized exemplar label copying in scrapework.addRowToTimeSeres Signed-off-by: Ted Possible <ted_possible@cable.comcast.com>
Refactored Openmetrics header to only be included if scrapeExemplars flag is set More comment formatting fixes Signed-off-by: Ted Possible <ted_possible@cable.comcast.com>
…uplicate exemplars remote writing. TODO: need better testing for this Signed-off-by: Ted Possible <ted_possible@cable.comcast.com>
…meseries Various formatting fixes Signed-off-by: Ted Possible <ted_possible@cable.comcast.com>
Signed-off-by: Ted Possible <ted_possible@cable.comcast.com>
…ved unnecessary Tags member from the struct since we can use tagsPool Signed-off-by: Ted Possible <ted_possible@cable.comcast.com>
…emplars on subsequent sends. We only need exemplars once per timeseries. Signed-off-by: Ted Possible <ted_possible@cable.comcast.com>
Signed-off-by: Ted Possible <ted_possible@cable.comcast.com>
Misc comment formatting Signed-off-by: Ted Possible <ted_possible@cable.comcast.com>
Signed-off-by: Ted Possible <ted_possible@cable.comcast.com>
TODO: Store exemplars in IndexDB Monthly Partition
…ol on WriteRequest - This must be a separate pool from labelsPool because protobuf fields can be out of order
|
Thanks for PR, but I think, there is no need at porting changes to the cluster branch. We'll doing it on our own later, those changes also ll be ported to the enterprise version by VM team. |
This PR is for support of OpenMetrics Exemplars all the way through the to the storage level. Since cluster and single-node are vastly different in their implementations of vmstorage I have chosen the one that best fits our use case which is the cluster version. There is more to come in this PR with IndexDB and mergeset as well as vmselect and updates to vmstorage API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for OpenMetrics exemplars implementation into vmcluster.