vmui/logs: add support for head|limit in expressions #6157
Conversation
| @@ -13,13 +13,21 @@ export const useFetchLogs = (server: string, query: string, limit: number) => { | |||
|
|
|||
| const url = useMemo(() => getLogsUrl(server), [server]); | |||
|
|
|||
| const prepareQuery = (query: string) => { | |||
| const limitRegex = /\|\s*(limit|head)\s*:?[\s-]*\d+/gm; | |||
There was a problem hiding this comment.
: is optional, you can have limit 10 or limit: 10
There was a problem hiding this comment.
and there will be more more things like that - so it worth to change logic of _time instead of add checks for limit
There was a problem hiding this comment.
yes, it works just like that, : is optional
There was a problem hiding this comment.
In any case, we need to wrap part of the expression in parentheses to ensure that the time range applies to all parts of the expression. Here is a more detailed explanation of why this is necessary: #5920.
At the moment, I don't understand what format such things will have, but perhaps we will be able to easily identify them and move them outside the brackets. If you have any ideas on how to change the logic, let me know.
As an alternative, it might be worth implementing support for query parameters for the time range to solve this problem on the server side.
There was a problem hiding this comment.
we are going to add | fields * or | fields container_name, level as next function, just keep in mind
|
This PR doesn't make sense after a6a599c. |
Adds correct handling of
head|limitin expressions.For example, the query
* | limit 10will be transformed into_time:[some_interval] AND (*) | limit 10.Related pull request: #6154.