Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

victoria-metrics: support to send logs to syslog server #6204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wasim-nihal
Copy link
Contributor

@wasim-nihal wasim-nihal commented Apr 29, 2024

Describe Your Changes

Changes to support sending of logs to syslog server. See #5903.

This change uses the Rackspace syslog package (https://github.com/RackSec/srslog) to send logs to syslog server. The standard log/syslog package is not implemented for windows that cause the windows builds to fail. This package has the support for TLS+TCP communication with syslog server.

The standard syslog documentation mentions the below points:

Bugs
This package is not implemented on Windows. As the syslog package is frozen, Windows users are encouraged to use a package outside of the standard library. For background, see https://golang.org/issue/1108.

This package is not implemented on Plan 9.

Note: Currently, this change does not support sending logs to syslog with "TCP+TLS". Once it's decided to use this syslog package or to maintain one within the Victoria Metrics' `/lib', the TLS support can be implemented.

See previous implementation by @khushijain21

Checklist

The following checks are mandatory:

Signed-off-by: Syed Nihal <syed.nihal@nokia.com>
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 56.84%. Comparing base (8aaa828) to head (2103a8c).
Report is 633 commits behind head on master.

Files Patch % Lines
lib/syslog/syslog.go 0.00% 17 Missing ⚠️
lib/logger/logger.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6204      +/-   ##
==========================================
- Coverage   60.37%   56.84%   -3.53%     
==========================================
  Files         411      528     +117     
  Lines       76609    72474    -4135     
==========================================
- Hits        46253    41201    -5052     
- Misses      27794    28373     +579     
- Partials     2562     2900     +338     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Syed Nihal <syed.nihal@nokia.com>
@wasim-nihal wasim-nihal marked this pull request as ready for review May 10, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant