Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: correctly apply -inmemoryDataFlushInterval when it's set t… #6221

Merged
merged 2 commits into from May 13, 2024

Conversation

Haleygo
Copy link
Collaborator

@Haleygo Haleygo commented May 6, 2024

…o minimum supported value 1s
pendingRowsFlushInterval was bumped to 2s in 73f0a80

Checklist

The following checks are mandatory:

@Haleygo Haleygo requested review from valyala and hagen1778 May 6, 2024 07:45
lib/storage/partition.go Outdated Show resolved Hide resolved
@Haleygo Haleygo requested a review from hagen1778 May 9, 2024 03:11
@Haleygo Haleygo force-pushed the fix-minimum-inmemoryDataFlushInterval branch from dc4482e to f7409b5 Compare May 9, 2024 03:12
@hagen1778 hagen1778 force-pushed the fix-minimum-inmemoryDataFlushInterval branch from f7409b5 to 23afd05 Compare May 13, 2024 13:42
@hagen1778 hagen1778 force-pushed the fix-minimum-inmemoryDataFlushInterval branch from 23afd05 to 78b58f4 Compare May 13, 2024 14:40
Copy link
Collaborator

@hagen1778 hagen1778 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hagen1778 hagen1778 merged commit 4c80b17 into master May 13, 2024
8 checks passed
@hagen1778 hagen1778 deleted the fix-minimum-inmemoryDataFlushInterval branch May 13, 2024 14:44
hagen1778 pushed a commit that referenced this pull request May 13, 2024
#6221)

…o minimum supported value 1s
pendingRowsFlushInterval was bumped to 2s in
73f0a80

(cherry picked from commit 4c80b17)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants